hover note css not working due to error in note_popup PHP

kcionline · Joined: 07 Oct 2008 Posts: 2

Changing the popup note css file makes no difference for reasons yet unknown.

However, if you change the 'style' statement in the related popup note PHP file (in the includes directory), you can alter the note styling. By default, in my install, the hover notes are transparent making them difficult to read but cool to look at.

If you add a background: #xxxxxx ; (or whatever color) to the appropriate class in the popup notes css, nothing happens. Add the same thing to the 'style' statement in the note_popup PHP file, the background on the note changes!. Also, by default, the variable used to specify the css class is incorrectly referenced. In the echo statement, to include a variable I would have thought you need to enclose variables in between dots like .$variable.. But I found there were not dots and consequently an error appears on the page. I'm no coder but it looked obvious to me..? in any case it seemed to make a difference.

If it's a bug I'd rather you guys fixed it rather than me hacking the core? unless I'm missing something?

esoft_ian · Joined: 12 Sep 2005 Posts: 5279

Hi,

It is because you have "Theme event note popups" selected in Admin -> Site Settings -> Misc. If you unselect this option, the notes_popups.css file will be used rather than style defined in the theme.

If you are referring to this portion:

class='{$note_class}'

in include/event_notes_popup.php, it is correct syntax. If not, can you tell me where you are seeing this please?

kcionline · Joined: 07 Oct 2008 Posts: 2

Oops! you are absolutely right!. My mistake entirely.

I spent ages hunting all over for an option like that. When I couldn't find it I guess I dived in and started changing things around.

Would be good if the popup notes css was easier to find along with the option. That way non-coders like me would not have to go digging around at all. What about putting the note css in the theme?

Absolutely brilliant software though. It's the only thing that offers all the functionality, flexibility and highly responsive support we need.

many thanks